linux-kernel - Re: [PATCH v2] mmc: tegra: fix SDR50 tuning override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9ad68894-fe90-4fb1-47b9-2304dee5b902@intel.com>
Date:   Tue, 7 Jan 2020 09:23:23 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
        Thierry Reding <treding@...dia.com>
Subject: Re: [PATCH v2] mmc: tegra: fix SDR50 tuning override

On 6/01/20 2:36 pm, Michał Mirosław wrote:
> Commit 7ad2ed1dfcbe inadvertently mixed up a quirk flag's name and
> broke SDR50 tuning override. Use correct NVQUIRK_ name.
> 
> Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes")
> Cc: <stable@...r.kernel.org> # 4f6aa3264af4: mmc: tegra: Only advertise UHS modes if IO regulator is present
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

You should have included Thierry's Reviewed-by and Tested-by

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  v2: converted 'Depends-On' tag to proper 'Cc: stable' lines
> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7bc950520fd9..403ac44a7378 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -386,7 +386,7 @@ static void tegra_sdhci_reset(struct sdhci_host *host, u8 mask)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_DDR50;
>  		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR104)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_SDR104;
> -		if (soc_data->nvquirks & SDHCI_MISC_CTRL_ENABLE_SDR50)
> +		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR50)
>  			clk_ctrl |= SDHCI_CLOCK_CTRL_SDR50_TUNING_OVERRIDE;
>  	}
>  
>