linux-kernel - Re: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <650f957c95e2ee99db646fe620268ff9@walle.cc>
Date:   Tue, 07 Jan 2020 09:32:15 +0100
From:   Michael Walle <michael@...le.cc>
To:     Kuldeep Singh <kuldeep.singh@....com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yogesh Gaur <yogeshgaur.83@...il.com>,
        Ashish Kumar <ashish.kumar@....com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem
 operations

Am 2020-01-07 06:39, schrieb Kuldeep Singh:
> Hi Michael,
> 
>> -----Original Message-----
>> From: linux-kernel-owner@...r.kernel.org <linux-kernel-
>> owner@...r.kernel.org> On Behalf Of Michael Walle
>> Sent: Thursday, December 12, 2019 1:28 AM
>> To: linux-spi@...r.kernel.org; linux-kernel@...r.kernel.org
>> Cc: Yogesh Gaur <yogeshgaur.83@...il.com>; Ashish Kumar
>> <ashish.kumar@....com>; Mark Brown <broonie@...nel.org>; Michael
>> Walle <michael@...le.cc>
>> Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in 
>> spi-mem
>> operations
>> 
>> Caution: EXT Email
>> 
>> Make use of a core helper to ensure the desired width is respected 
>> when
>> calling spi-mem operators.
>> 
>> Otherwise only the SPI controller will be matched with the flash chip, 
>> which
>> might lead to wrong widths. Also consider the width specified by the 
>> user in
>> the device tree.
> 
> Could you please mention the flash and modes you tested. Does it
> support DUAL/QUAD mode?
> I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which
> supports SINGLE and OCTAL modes only.

That commit is already upstream. But FWIW, it was a Winbond W25Q32FW in 
dual i/o mode.

-michael