linux-kernel - Re: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200107084551.GB31906@pi3>
Date:   Tue, 7 Jan 2020 09:45:51 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Yangtao Li <tiny.windzz@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, kgene@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: exynos: tiny4412: add fimd node

On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote:
> The patch adds fimd node for tiny4412 device.

Hi,

Thanks for the patch.

Do not use "This patch ..." sentences but simple, imperative mode:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151

Here you do not add FIMD node, because the FIMD is already there
(defined in exynos4.dtsi).  You however enable it.

Enabling it without panel does not really make sense - does it work?
I guess not, so this should be squashed with second patch.

Best regards,
Krzysztof

> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> index 01f37b5ac9c4..2b62cb27420c 100644
> --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
> +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
> @@ -68,6 +68,14 @@
>  	};
>  };
>  
> +&fimd {
> +	pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
> +	pinctrl-names = "default";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +};
> +
>  &rtc {
>  	status = "okay";
>  };
> -- 
> 2.17.1
>