linux-kernel - Re: [PATCH] coccinnelle: Remove ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jan 2020 10:40:33 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Julia.Lawall@...6.fr, Gilles.Muller@...6.fr, nicolas.palix@...g.fr,
        michal.lkml@...kovi.net, cocci@...teme.lip6.fr,
        linux-kernel@...r.kernel.org,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] coccinnelle: Remove ptr_ret script

On Tue, Jan 07, 2020 at 08:36:29AM +0100, Maxime Ripard wrote:
> The ptr_ret script script addresses a number of situations where we end up
> testing an error pointer, and if it's an error returning it, or return 0
> otherwise to transform it into a PTR_ERR_OR_ZERO call.
> 
> So it will convert a block like this:
> 
> if (IS_ERR(err))
>     return PTR_ERR(err);
> 
> return 0;
> 
> into
> 
> return PTR_ERR_OR_ZERO(err);
> 
> While this is technically correct, it has a number of drawbacks. First, it
> merges the error and success path, which will make it harder for a reviewer
> or reader to grasp.
> 
> It's also more difficult to extend if we were to add some code between the
> error check and the function return, making the author essentially revert
> that patch before adding new lines, while it would have been a trivial
> addition otherwise for the rewiever.
> 
> Therefore, since that script is only about cosmetic in the first place,
> let's remove it since it's not worth it.
> 
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Maxime Ripard <maxime@...no.tech>
> ---
>  scripts/coccinelle/api/ptr_ret.cocci | 97 ----------------------------
>  1 file changed, 97 deletions(-)
>  delete mode 100644 scripts/coccinelle/api/ptr_ret.cocci

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)