linux-kernel - Re: [PATCH 25/32] pwm: brcmstb: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fde9b416b281648e99b3ce430229e89c5b1a653.camel@suse.de>
Date:   Tue, 07 Jan 2020 11:54:53 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Yangtao Li <tiny.windzz@...il.com>, claudiu.beznea@...rochip.com,
        thierry.reding@...il.com, u.kleine-koenig@...gutronix.de,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        ludovic.desroches@...rochip.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        f.fainelli@...il.com, shc_work@...l.ru, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, vz@...ia.com, slemieux.tyco@...il.com,
        khilman@...libre.com, matthias.bgg@...il.com, heiko@...ech.de,
        palmer@...belt.com, paul.walmsley@...ive.com, mripard@...nel.org,
        wens@...e.org, jonathanh@...dia.com, linux@...sktech.co.nz,
        linux-arm-kernel@...ts.infradead.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org,
        linux-riscv@...ts.infradead.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 25/32] pwm: brcmstb: convert to
 devm_platform_ioremap_resource

On Sun, 2019-12-29 at 08:06 +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Thanks!

>  drivers/pwm/pwm-brcmstb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
> index fea612c45f20..8b66f9d2f589 100644
> --- a/drivers/pwm/pwm-brcmstb.c
> +++ b/drivers/pwm/pwm-brcmstb.c
> @@ -234,7 +234,6 @@ MODULE_DEVICE_TABLE(of, brcmstb_pwm_of_match);
>  static int brcmstb_pwm_probe(struct platform_device *pdev)
>  {
>  	struct brcmstb_pwm *p;
> -	struct resource *res;
>  	int ret;
>  
>  	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> @@ -262,8 +261,7 @@ static int brcmstb_pwm_probe(struct platform_device *pdev)
>  	p->chip.base = -1;
>  	p->chip.npwm = 2;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	p->base = devm_ioremap_resource(&pdev->dev, res);
> +	p->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(p->base)) {
>  		ret = PTR_ERR(p->base);
>  		goto out_clk;


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)