linux-kernel - Re: [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in non-deferrable mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jan 2020 16:33:24 +0530
From:   Bhaskar Upadhaya <bhaskar.upadhaya.linux@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Bhaskar Upadhaya <bupadhaya@...vell.com>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-edac@...r.kernel.org, lenb@...nel.org, rafael@...nel.org,
        gkulkarni@...vell.com, rrichter@...vell.com
Subject: Re: [RFC PATCH] apei/ghes: fix ghes_poll_func by registering in
 non-deferrable mode

On Mon, Jan 6, 2020 at 6:39 PM Borislav Petkov <bp@...en8.de> wrote:
>
> On Mon, Jan 06, 2020 at 04:33:19PM +0530, Bhaskar Upadhaya wrote:
> > Definition of poll interval as per spec (referred ACPI 6.3):
> > "Indicates the poll interval in milliseconds OSPM should use to
> > periodically check the error source for the presence of an error
> > condition."
>
> Please add that...
>
> > We are observing an issue in our ThunderX2 platforms wherein
> > ghes_poll_func is not called within poll interval when timer is
> > configured with TIMER_DEFERRABLE flag(For NO_HZ kernel) and hence we
> > are losing the error records.
>
> ... and that to your commit message then, so that it is crystal clear
> *why* you're making this change.

Thanks Borislav, I will edit the commit message with you comments in
the next patch.
Can I get your Ack in the next patch ?

>
> Thx.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette