linux-kernel - Re: [PATCH] pinctrl: artpec6: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200107111836.uzvja6m4nb5hh56j@axis.com>
Date:   Tue, 7 Jan 2020 12:18:36 +0100
From:   Jesper Nilsson <jesper.nilsson@...s.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        Jesper Nilsson <jespern@...s.com>,
        Lars Persson <larper@...s.com>,
        linux-arm-kernel <linux-arm-kernel@...s.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: artpec6: fix __iomem on reg in set

On Tue, Jan 07, 2020 at 10:39:34AM +0100, Linus Walleij wrote:
> On Wed, Dec 18, 2019 at 6:32 PM Ben Dooks <ben.dooks@...ethink.co.uk> wrote:
> > On 18/12/2019 16:26, Jesper Nilsson wrote:
> > > On Wed, Dec 18, 2019 at 11:16:02AM +0100, Ben Dooks (Codethink) wrote:
> 
> > >> -    unsigned int *reg;
> > >> +    unsigned int __iomem *reg;
> > >
> > >       void __iomem *reg;
> > >
> > > We're using as an argument to readl()?
> >
> > yes, readl() shoud take an __iomem attributed pointer.
> 
> Shall I change it to void as well when applying?

Please do, sorry that my comment wasn't clear above.

> Yours,
> Linus Walleij

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com