linux-kernel - RE: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9DD61F30A802C4429A01CA4200E302A7C1DF97F0@fmsmsx123.amr.corp.intel.com>
Date:   Tue, 7 Jan 2020 02:08:41 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Jason Gunthorpe <jgg@...pe.ca>, Xiyu Yang <xiyuyang19@...an.edu.cn>
CC:     "yuanxzhang@...an.edu.cn" <yuanxzhang@...an.edu.cn>,
        "kjlu@....edu" <kjlu@....edu>, "leon@...nel.org" <leon@...nel.org>,
        "Markus.Elfring@....de" <Markus.Elfring@....de>,
        Xin Tan <tanxin.ctf@...il.com>,
        "Latif, Faisal" <faisal.latif@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Shannon Nelson <shannon.nelson@...el.com>,
        "Singhai, Anjali" <anjali.singhai@...el.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer
 dereference

> Subject: Re: [PATCH v4] infiniband: i40iw: fix a potential NULL pointer dereference
> 
> On Mon, Dec 30, 2019 at 10:24:28AM +0800, Xiyu Yang wrote:
> > A NULL pointer can be returned by in_dev_get(). Thus add a
> > corresponding check so that a NULL pointer dereference will be avoided
> > at this place.
> >
> > Fixes: 8e06af711bf2 ("i40iw: add main, hdr, status")
> > Signed-off-by: Xiyu Yang <xiyuyang19@...an.edu.cn>
> > Signed-off-by: Xin Tan <tanxin.ctf@...il.com>
> > Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> > ---
> > Changes in v2:
> > - Release rtnl lock when in_dev_get return NULL Changes in v3:
> > - Continue the next loop when in_dev_get return NULL Changes in v4:
> > - Change commit message
> >
> >  drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Applied to for-next
> 
> And Shiraz, Leon is right, that trylock stuff is completely wrong, let's fix it.
> 

Sure.