linux-kernel - Re: [PATCH] security: selinux: allow per-file labelling for binderfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 6 Jan 2020 21:13:42 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Hridya Valsaraju <hridya@...gle.com>
Cc:     Eric Paris <eparis@...isplace.org>, selinux@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Android Kernel Team <kernel-team@...roid.com>,
        Jeff Vander Stoep <jeffv@...gle.com>,
        Mark Salyzyn <salyzyn@...roid.com>,
        Stephen Smalley <sds@...ho.nsa.gov>
Subject: Re: [PATCH] security: selinux: allow per-file labelling for binderfs

On Mon, Jan 6, 2020 at 2:33 PM Stephen Smalley <sds@...ho.nsa.gov> wrote:
> On 1/6/20 2:06 PM, Hridya Valsaraju wrote:
> > On Mon, Jan 6, 2020 at 10:33 AM 'Stephen Smalley' via kernel-team
> > <kernel-team@...roid.com> wrote:
> >>
> >> On 1/6/20 1:13 PM, Hridya Valsaraju wrote:
> >>> This patch allows genfscon per-file labeling for binderfs.
> >>> This is required to have separate permissions to allow
> >>> access to binder, hwbinder and vndbinder devices which are
> >>> relocating to binderfs.
> >>>
> >>> Acked-by: Jeff Vander Stoep <jeffv@...gle.com>
> >>> Acked-by: Mark Salyzyn <salyzyn@...roid.com>
> >>> Signed-off-by: Hridya Valsaraju <hridya@...gle.com>
> >>
> >> Do you want binderfs to also support userspace labeling of files via
> >> setxattr()?  If so, you'll want to also add it to
> >> selinux_is_genfs_special_handling() as well.
> >
> > Thank you for the quick response Stephen :) I cannot think of a
> > use-case for the userspace labelling of files in binderfs via
> > setxattr() as of now. I
> > will make the change if one comes up!
>
> Ok, then you can include my:
> Acked-by: Stephen Smalley <sds@...ho.nsa.gov>

Merged into selinux/next, thanks everyone!

-- 
paul moore
www.paul-moore.com