linux-kernel - Re: [PATCH v4 00/13] gpiolib: add an ioctl() for monitoring line status changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10721bebc81144c25e53b55c8cd086a34d4fd1f8.camel@seibold.net>
Date:   Tue, 07 Jan 2020 14:15:59 +0100
From:   Stefani Seibold <stefani@...bold.net>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Kent Gibson <warthog618@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/13] gpiolib: add an ioctl() for monitoring line
 status changes

Am Dienstag, den 07.01.2020, 13:50 +0100 schrieb Linus Walleij:
> On Tue, Jan 7, 2020 at 11:38 AM Bartosz Golaszewski
> <bgolaszewski@...libre.com> wrote:
> > wt., 7 sty 2020 o 11:07 Linus Walleij <linus.walleij@...aro.org>
> > napisał(a):
> > > The patch set overall looks good to me, I don't understand the
> > > kfifo
> > > parts but I trust you on this, though we need review from a FIFO
> > > maintainer.
> > 
> > Ha! This may be a problem - there doesn't seem to be one. This is
> > why
> > I Cc'd Greg.
> 
> I was under the impression that KFIFO was part of the driver core.
> Let's try to CC the actual author (Stefani Seibold) and see if the
> mail
> address works and if he can look at it. Or did you already talk to
> Stefani?
> 
> (git blame is always my best friend in cases like this, hehe)
> 
> Yours,
> Linus Walleij

I have looked around for the patches and I found the following patches 

[PATCH v4 07/13] kfifo: provide noirqsave variants of spinlocked in and out helpers
[PATCH v4 08/13] kfifo: provide kfifo_is_empty_spinlocked()

dated on 24 Dec 2019.

Both seems to be okay. The patch is non intrusive to KFIFO adding only
spinlock wrapper functions for the contemporary kfifo functions.

So...

Acked by Stefani Seibold <stefani@...bold.net>