linux-kernel - Re: [PATCH -next] drm/i915: Add missing include file <linux/math64.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 07 Jan 2020 13:53:21 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     airlied@...ux.ie, daniel@...ll.ch, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, matthew.auld@...el.com,
        rodrigo.vivi@...el.com, tvrtko.ursulin@...el.com,
        ville.syrjala@...ux.intel.com, yuehaibing@...wei.com
Cc:     intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/i915: Add missing include file <linux/math64.h>

Quoting YueHaibing (2020-01-07 13:50:14)
> Fix build error:
> ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state:
> ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
>  implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration]
>   return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result")

While technically true, that doesn't explain why it only just started
appearing on -next.
-Chris