linux-kernel - Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLW-pLkeDodqNWg-TtsKTi6Rak_z9Gki3FJSLReqO+arPg@mail.gmail.com>
Date:   Tue, 7 Jan 2020 09:23:24 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     lkml <linux-kernel@...r.kernel.org>, Todd Kjos <tkjos@...gle.com>,
        Alistair Delva <adelva@...gle.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [PATCH] reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate

On Tue, Jan 7, 2020 at 12:32 AM Philipp Zabel <p.zabel@...gutronix.de> wrote:
> On Tue, 2020-01-07 at 01:03 +0000, John Stultz wrote:
> > Allow CONFIG_RESET_QCOM_AOSS to be set as as =m
> > to allow for the driver to be loaded from a modules.
> >
> > Cc: Todd Kjos <tkjos@...gle.com>
> > Cc: Alistair Delva <adelva@...gle.com>
> > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Cc: Amit Pundir <amit.pundir@...aro.org>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Signed-off-by: John Stultz <john.stultz@...aro.org>
> > ---
> >  drivers/reset/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 3ad7817ce1f0..45e70524af36 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -99,7 +99,7 @@ config RESET_PISTACHIO
> >         This enables the reset driver for ImgTec Pistachio SoCs.
> >
> >  config RESET_QCOM_AOSS
> > -     bool "Qcom AOSS Reset Driver"
> > +     tristate "Qcom AOSS Reset Driver"
>
> This doesn't seem right on its own, the driver still uses
> builtin_platform_driver().

Huh. Thanks for pointing that out!
It seems like it was working fine as a module with just the kconfig
change, but let me double check this and I'll revise with a follow-on
patch to address this bit.

Very much appreciate the review!

thanks
-john