linux-kernel - Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLGJehgW6c=GbyFSV8hL+WsUEkRzEBO0_kEka-d2nQ8pw@mail.gmail.com>
Date:   Tue, 7 Jan 2020 12:02:52 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Benjamin Gaignard <benjamin.gaignard@...com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Linux Input <linux-input@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Yannick Fertre <yannick.fertre@...com>
Subject: Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen
 to json-schema

On Tue, Jan 7, 2020 at 7:38 AM Bastien Nocera <hadess@...ess.net> wrote:
>
> On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote:
> > Convert the Goodix binding to DT schema format using json-schema
>
> I don't have an opinion on the migration itself, but this really should
> not lose any of the descriptions that were in the old text file.

To some extent, yes. Any information specific to the device should be.
Anything generic can be dropped. I see 2 cases that should be kept:

> > - - reg                       : I2C address of the chip. Should be
> > 0x5d or 0x14

'I2C address of the chip' can be dropped as that's every 'reg'
property for I2C devices. The addresses can be expressed as
constraints.

> > - - irq-gpios         : GPIO pin used for IRQ. The driver uses the
> > -                       interrupt gpio pin as output to reset the
> > device.

Also useful info.

Rob