linux-kernel - Re: EDAC driver for DMC520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3dc9a736-16c9-7e87-b27c-bf3029d1a37f@gmail.com>
Date:   Tue, 7 Jan 2020 11:18:42 -0800
From:   Shiping Ji <shiping.linux@...il.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Borislav Petkov <bp@...en8.de>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        Yuqing Shen <yuqing.shen@...adcom.com>,
        Lei Wang <lewan@...rosoft.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: EDAC driver for DMC520

Hi Scott,

On 1/7/2020 11:13 AM, Scott Branden wrote:
> Hi Shiping,
> 
> On 2020-01-07 11:01 a.m., Shiping Ji wrote:
>> On 1/7/2020 10:55 AM, Scott Branden wrote:
>>> Lei/Shiping,
>>>
>>> On 2020-01-07 10:49 a.m., Borislav Petkov wrote:
>>>> On Tue, Jan 07, 2020 at 09:57:26AM -0800, Scott Branden wrote:
>>>>> Hello EDAC Maintainers,
>>>>>
>>>>> Could somebody have a look at the DMC520 patch series that has been waiting
>>>>> for a response since November:
>>>>> https://patchwork.kernel.org/patch/11248785/
>>>> Well, the dt bindings stuff is still being discussed:
>>>>
>>>> https://patchwork.kernel.org/patch/11248783/
> Shiping, you also need to address the binding comment here.

Yes, I'm currently working on the dt-binding changes.

>>>>
>>>> Also, looking at this again, the patch authorship looks really fishy:
>>>>
>>>> Sender is
>>>>
>>>> From: Shiping Ji <shiping.linux@...il.com>
>>>>
>>>> however, he doesn't have his SOB in there and previous iterations were
>>>> done with Lei Wang whose SOB *is* there so I dunno what's going on.
>>>>
>>>> *Especially* if Lei Wang is being added as a maintainer of that driver
>>>> by the second patch but he's not sending this driver himself. If this
>>>> driver is going to be orphaned the moment it lands upstream, I'm not
>>>> going to take it.
>>> Shiping/Lei could you please provide appropriate signed-off-by?
>>> Also, if you do not have an appropriate maintainer for the driver
>>> we have Yuqing Shen who can be maintainer of this driver.
>> Yes, signed-off-by is still Lei Wang, who is still the official maintainer of the driver.
>>
>> Lei is currently in sick leave so I'm trying to complete the patches on her behalf. Please kindly let me know how to add my SOB there.
> If Lei is coming back soon then it may be best to wait for her?

It may take another couple of months for her to return, we'd like to complete the current patches since these have been active for quite long time (almost one year).

> Either way, I highly suggest you read the kernel documentation on submitting patches in the source tree:
> Documentation/process/submitting-patches.rst.
> 
> Also, some of your other coworkers must know how to upstream code and can help you follow the process?

Yes, I followed the notes but apparently have missed some important steps. I'll go the above document and get it fixed.

The new patches are expected in a couple of days.

>> Thanks!
>>
>>>> So at least those two things need to be fixed/clarified first.
>>>>
>>>> HTH.
>>>>
> 


-- 
Best regards,
Shiping Ji