linux-kernel - [PATCH 3.16 24/63] mmc: block: Allow more than 8 partitions per card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1578512578.249229927@decadent.org.uk>
Date:   Wed, 08 Jan 2020 19:43:22 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        "Colin Cross" <ccross@...roid.com>,
        "Arnd Bergmann" <arnd@...db.de>,
        "John Stultz" <john.stultz@...aro.org>,
        "Ulf Hansson" <ulf.hansson@...aro.org>,
        "Shawn Lin" <shawn.lin@...k-chips.com>,
        "Adrian Hunter" <adrian.hunter@...el.com>,
        linux-mmc@...r.kernel.org,
        "Android Kernel Team" <kernel-team@...roid.com>,
        "Austin S Hemmelgarn" <ahferroin7@...il.com>,
        "Chuanxiao Dong" <chuanxiao.dong@...el.com>
Subject: [PATCH 3.16 24/63] mmc: block: Allow more than 8 partitions per card

3.16.81-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Colin Cross <ccross@...roid.com>

commit 382c55f88ffeb218c446bf0c46d0fc25d2795fe2 upstream.

It is quite common for Android devices to utilize more
then 8 partitions on internal eMMC storage.

The vanilla kernel can support this via
CONFIG_MMC_BLOCK_MINORS, however that solution caps the
system to 256 minors total, which limits the number of
mmc cards the system can support.

This patch, which has been carried for quite awhile in
the AOSP common tree, provides an alternative solution
that doesn't seem to limit the total card count. So I
wanted to submit it for consideration upstream.

This patch sets the GENHD_FL_EXT_DEVT flag, which will
allocate minor number in major 259 for partitions past
disk->minors.

It also removes the use of disk_devt to determine devidx
from md->disk. md->disk->first_minor is always initialized
from devidx and can always be used to recover it.

Cc: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: Ben Hutchings <ben@...adent.org.uk>
Cc: Chuanxiao Dong <chuanxiao.dong@...el.com>
Cc: Shawn Lin <shawn.lin@...k-chips.com>
Cc: Austin S Hemmelgarn <ahferroin7@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>
Cc: Android Kernel Team <kernel-team@...roid.com>
Cc: linux-mmc@...r.kernel.org
Signed-off-by: Colin Cross <ccross@...roid.com>
[jstultz: Added context to commit message]
Signed-off-by: John Stultz <john.stultz@...aro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Arnd Bergmann <arnd@...db.de>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 drivers/mmc/card/block.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -168,11 +168,7 @@ static struct mmc_blk_data *mmc_blk_get(
 
 static inline int mmc_get_devidx(struct gendisk *disk)
 {
-	int devmaj = MAJOR(disk_devt(disk));
-	int devidx = MINOR(disk_devt(disk)) / perdev_minors;
-
-	if (!devmaj)
-		devidx = disk->first_minor / perdev_minors;
+	int devidx = disk->first_minor / perdev_minors;
 	return devidx;
 }
 
@@ -2169,6 +2165,7 @@ static struct mmc_blk_data *mmc_blk_allo
 	md->disk->queue = md->queue.queue;
 	md->disk->driverfs_dev = parent;
 	set_disk_ro(md->disk, md->read_only || default_ro);
+	md->disk->flags = GENHD_FL_EXT_DEVT;
 	if (area_type & MMC_BLK_DATA_AREA_RPMB)
 		md->disk->flags |= GENHD_FL_NO_PART_SCAN;