linux-kernel - Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a267a03595c613a4c44d379706d8f1a5d6e30035.camel@redhat.com>
Date:   Wed, 08 Jan 2020 16:27:55 -0500
From:   "Ewan D. Milne" <emilne@...hat.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     James Bottomley <jejb@...ux.ibm.com>, axboe@...nel.dk,
        Chaitanya.Kulkarni@....com, mst@...hat.com,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-block@...r.kernel.org, ssomesh@...zon.com,
        Balbir Singh <sblbir@...zon.com>, hch@....de
Subject: Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use
 disk_set_capacity

On Tue, 2020-01-07 at 21:59 -0500, Martin K. Petersen wrote:
> Ewan,
> 
> > Yes, there are some storage arrays that refuse a READ CAPACITY
> > command in certain ALUA states so you can't get the new capacity
> > anyway.
> 
> Yep. And some devices will temporarily return a capacity of
> 0xFFFFFFFF... If we were to trigger a filesystem resize, the results
> would be disastrous.
> 
> > It might be nice to improve this, though, there are some cases now
> > where we set the capacity to zero when we revalidate and can't get the
> > value.
> 
> If you have a test case, let's fix it.
> 

This happens with NVMe fabric devices, I thought.  I'll check.