lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jan 2020 14:50:10 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Max Gurtovoy <maxg@...lanox.com>, linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org Cc: Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <chaitanya.kulkarni@....com>, Stephen Bates <sbates@...thlin.com>, Jens Axboe <axboe@...com>, Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de> Subject: Re: [PATCH v10 6/9] nvme: Export existing nvme core functions On 2020-01-08 2:48 p.m., Max Gurtovoy wrote: > > On 1/8/2020 7:40 PM, Logan Gunthorpe wrote: >> Export nvme_put_ns(), nvme_command_effects(), nvme_execute_passthru_rq() >> and nvme_find_get_ns() for use in the nvmet passthru code. >> >> The exports are conditional on CONFIG_NVME_TARGET_PASSTHRU. >> >> Based-on-a-patch-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com> >> Signed-off-by: Logan Gunthorpe <logang@...tatee.com> >> --- >> drivers/nvme/host/core.c | 14 +++++++++----- >> drivers/nvme/host/nvme.h | 5 +++++ >> 2 files changed, 14 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c >> index d7912e7a9911..037415882d46 100644 >> --- a/drivers/nvme/host/core.c >> +++ b/drivers/nvme/host/core.c >> @@ -463,7 +463,7 @@ static void nvme_free_ns(struct kref *kref) >> kfree(ns); >> } >> -static void nvme_put_ns(struct nvme_ns *ns) >> +void nvme_put_ns(struct nvme_ns *ns) >> { >> kref_put(&ns->kref, nvme_free_ns); >> } >> @@ -896,8 +896,8 @@ static void *nvme_add_user_metadata(struct bio >> *bio, void __user *ubuf, >> return ERR_PTR(ret); >> } >> -static u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct >> nvme_ns *ns, >> - u8 opcode) >> +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, >> + u8 opcode) >> { >> u32 effects = 0; >> @@ -982,7 +982,7 @@ static void nvme_passthru_end(struct nvme_ctrl >> *ctrl, u32 effects) >> nvme_queue_scan(ctrl); >> } >> -static void nvme_execute_passthru_rq(struct request *rq) >> +void nvme_execute_passthru_rq(struct request *rq) >> { >> struct nvme_command *cmd = nvme_req(rq)->cmd; >> struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl; >> @@ -3441,7 +3441,7 @@ static int ns_cmp(void *priv, struct list_head >> *a, struct list_head *b) >> return nsa->head->ns_id - nsb->head->ns_id; >> } >> -static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, >> unsigned nsid) >> +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid) >> { >> struct nvme_ns *ns, *ret = NULL; >> @@ -4225,6 +4225,10 @@ EXPORT_SYMBOL_GPL(nvme_sync_queues); >> * use by the nvmet-passthru and should not be used for >> * other things. >> */ >> +EXPORT_SYMBOL_GPL(nvme_put_ns); >> +EXPORT_SYMBOL_GPL(nvme_command_effects); >> +EXPORT_SYMBOL_GPL(nvme_execute_passthru_rq); >> +EXPORT_SYMBOL_GPL(nvme_find_get_ns); > > Since this is the convention in the driver, can you export the symbols > at the end of each function ? Christoph specifically asked for these to be exported at the end of the file within an #ifdef CONFIG_NVME_TARGET_PASSTHRU. Logan
Powered by blists - more mailing lists