linux-kernel - Re: [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hwo_NzspnM551DjJOKsJNV8ssT_FKwpj3qfhZ+r-ebJg@mail.gmail.com>
Date:   Wed, 8 Jan 2020 23:29:24 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Andy Gross <agross@...nel.org>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Kevin Hilman <khilman@...nel.org>, Nishanth Menon <nm@...com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init()

On Wed, Jan 8, 2020 at 6:34 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> We're returning the wrong variable.  "ret" isn't initialized.
>
> Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  drivers/power/avs/qcom-cpr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9247f53550b3..0321729431a5 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
>                 uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage,
>                                       step_volt, drv);
>                 if (uV < 0)
> -                       return ret;
> +                       return uV;
>
>                 fuse->min_uV = fdata->min_uV;
>                 fuse->max_uV = fdata->max_uV;
> --

Thanks for the fix, but this issue has been fixed already.