linux-kernel - Re: [PATCH v7 13/21] ASoC: tegra: Use device managed resource APIs to get the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <692ae1f9-ec01-f0e9-9b9a-a0eba3f32e44@nvidia.com>
Date:   Wed, 8 Jan 2020 10:56:23 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Sowjanya Komatineni <skomatineni@...dia.com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <broonie@...nel.org>, <lgirdwood@...il.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <digetx@...il.com>, <mperttunen@...dia.com>,
        <gregkh@...uxfoundation.org>, <sboyd@...nel.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>
CC:     <pdeschrijver@...dia.com>, <pgaikwad@...dia.com>,
        <josephl@...dia.com>, <daniel.lezcano@...aro.org>,
        <mmaddireddy@...dia.com>, <markz@...dia.com>,
        <devicetree@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 13/21] ASoC: tegra: Use device managed resource APIs to
 get the clock


On 1/8/2020 9:55 AM, Sowjanya Komatineni wrote:
> tegra_asoc_utils uses clk_get() and clk_put() to get the clock
> and to free them explicitly.
>
> This patch updates it to use device managed resource API
> devm_clk_get() so the clock will be automatically released and freed
> when the device is unbound and removes tegra_asoc_utils_fini() as
> its no longer needed.
>
> Tested-by: Dmitry Osipenko <digetx@...il.com>
> Reviewed-by: Dmitry Osipenko <digetx@...il.com>
> Signed-off-by: Sowjanya Komatineni <skomatineni@...dia.com>

Reviewed-by: Sameer Pujar <spujar@...dia.com>

> ---
>   sound/soc/tegra/tegra_alc5632.c    |  7 +------
>   sound/soc/tegra/tegra_asoc_utils.c | 34 +++++++---------------------------
>   sound/soc/tegra/tegra_asoc_utils.h |  1 -
>   sound/soc/tegra/tegra_max98090.c   | 22 ++++++----------------
>   sound/soc/tegra/tegra_rt5640.c     | 22 ++++++----------------
>   sound/soc/tegra/tegra_rt5677.c     |  7 +------
>   sound/soc/tegra/tegra_sgtl5000.c   |  7 +------
>   sound/soc/tegra/tegra_wm8753.c     | 22 ++++++----------------
>   sound/soc/tegra/tegra_wm8903.c     | 22 ++++++----------------
>   sound/soc/tegra/tegra_wm9712.c     |  8 ++------
>   sound/soc/tegra/trimslice.c        | 18 ++++--------------
>   11 files changed, 40 insertions(+), 130 deletions(-)
. . .