lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jan 2020 00:21:51 -0600 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Claudiu Manoil <claudiu.manoil@....com>, "David S. Miller" <davem@...emloft.net>, Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "Gustavo A. R. Silva" <gustavo@...eddedor.com> Subject: [PATCH net-next] enetc: enetc_pci_mdio: Fix inconsistent IS_ERR and PTR_ERR Fix inconsistent IS_ERR and PTR_ERR in enetc_pci_mdio_probe(). The proper pointer to be passed as argument is hw. This bug was detected with the help of Coccinelle. Fixes: 6517798dd343 ("enetc: Make MDIO accessors more generic and export to include/linux/fsl") Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> --- drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c index 87c0e969da40..ebc635f8a4cc 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c @@ -27,7 +27,7 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev, } hw = enetc_hw_alloc(dev, port_regs); - if (IS_ERR(enetc_hw_alloc)) { + if (IS_ERR(hw)) { err = PTR_ERR(hw); goto err_hw_alloc; } -- 2.23.0
Powered by blists - more mailing lists