linux-kernel - Re: [PATCH] kernel/module: Fix memleak in module_add_modinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2001080905110.13391@pobox.suse.cz>
Date:   Wed, 8 Jan 2020 09:05:36 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     YueHaibing <yuehaibing@...wei.com>
cc:     jeyu@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/module: Fix memleak in
 module_add_modinfo_attrs()

On Sat, 28 Dec 2019, YueHaibing wrote:

> In module_add_modinfo_attrs() if sysfs_create_file() fails
> on the first iteration of the loop (so i = 0), we forget to
> free the modinfo_attrs.
> 
> Fixes: bc6f2a757d52 ("kernel/module: Fix mem leak in module_add_modinfo_attrs")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

M