linux-kernel - Re: [PATCH 1/3] udf: Fix spelling in EXT_NEXT_EXTENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200108101118.GB20521@quack2.suse.cz>
Date:   Wed, 8 Jan 2020 11:11:18 +0100
From:   Jan Kara <jack@...e.cz>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jan Kara <jack@...e.com>
Subject: Re: [PATCH 1/3] udf: Fix spelling in EXT_NEXT_EXTENT_ALLOCDESCS

Thanks! Much easier to review now :) I've queued your patches to my tree.

								Honza

On Tue 07-01-20 22:29:02, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> ---
>  fs/udf/ecma_167.h | 2 +-
>  fs/udf/inode.c    | 6 +++---
>  fs/udf/truncate.c | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h
> index fb7f2c7be..e7b889e01 100644
> --- a/fs/udf/ecma_167.h
> +++ b/fs/udf/ecma_167.h
> @@ -757,7 +757,7 @@ struct partitionIntegrityEntry {
>  #define EXT_RECORDED_ALLOCATED		0x00000000
>  #define EXT_NOT_RECORDED_ALLOCATED	0x40000000
>  #define EXT_NOT_RECORDED_NOT_ALLOCATED	0x80000000
> -#define EXT_NEXT_EXTENT_ALLOCDECS	0xC0000000
> +#define EXT_NEXT_EXTENT_ALLOCDESCS	0xC0000000
>  
>  /* Long Allocation Descriptor (ECMA 167r3 4/14.14.2) */
>  
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index ea80036d7..e875bc566 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1981,10 +1981,10 @@ int udf_setup_indirect_aext(struct inode *inode, udf_pblk_t block,
>  
>  		__udf_add_aext(inode, &nepos, &cp_loc, cp_len, 1);
>  		udf_write_aext(inode, epos, &nepos.block,
> -			       sb->s_blocksize | EXT_NEXT_EXTENT_ALLOCDECS, 0);
> +			       sb->s_blocksize | EXT_NEXT_EXTENT_ALLOCDESCS, 0);
>  	} else {
>  		__udf_add_aext(inode, epos, &nepos.block,
> -			       sb->s_blocksize | EXT_NEXT_EXTENT_ALLOCDECS, 0);
> +			       sb->s_blocksize | EXT_NEXT_EXTENT_ALLOCDESCS, 0);
>  	}
>  
>  	brelse(epos->bh);
> @@ -2143,7 +2143,7 @@ int8_t udf_next_aext(struct inode *inode, struct extent_position *epos,
>  	unsigned int indirections = 0;
>  
>  	while ((etype = udf_current_aext(inode, epos, eloc, elen, inc)) ==
> -	       (EXT_NEXT_EXTENT_ALLOCDECS >> 30)) {
> +	       (EXT_NEXT_EXTENT_ALLOCDESCS >> 30)) {
>  		udf_pblk_t block;
>  
>  		if (++indirections > UDF_MAX_INDIR_EXTS) {
> diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c
> index 63a47f1e1..532cda996 100644
> --- a/fs/udf/truncate.c
> +++ b/fs/udf/truncate.c
> @@ -241,7 +241,7 @@ int udf_truncate_extents(struct inode *inode)
>  
>  	while ((etype = udf_current_aext(inode, &epos, &eloc,
>  					 &elen, 0)) != -1) {
> -		if (etype == (EXT_NEXT_EXTENT_ALLOCDECS >> 30)) {
> +		if (etype == (EXT_NEXT_EXTENT_ALLOCDESCS >> 30)) {
>  			udf_write_aext(inode, &epos, &neloc, nelen, 0);
>  			if (indirect_ext_len) {
>  				/* We managed to free all extents in the
> -- 
> 2.20.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR