linux-kernel - Re: [PATCH] x86/boot: fix cast to pointer compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <049a6ca0-5f0d-0187-85d4-6d5f1e78af55@211mainstreet.net>
Date:   Wed, 8 Jan 2020 01:30:14 -0500
From:   Edwin Zimmerman <edwin@...mainstreet.net>
To:     Randy Dunlap <rdunlap@...radead.org>, x86@...nel.org,
        Matthew Garrett <mjg59@...gle.com>,
        linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Chao Fan <fanc.fnst@...fujitsu.com>,
        Junichi Nomura <j-nomura@...jp.nec.com>,
        Erik Schmauss <erik.schmauss@...el.com>,
        Zhenzhong Duan <zhenzhong.duan@...cle.com>,
        Josh Boyer <jwboyer@...hat.com>
Subject: Re: [PATCH] x86/boot: fix cast to pointer compiler warning

On 1/7/2020 8:18 PM, Randy Dunlap wrote:
> On 1/7/20 9:38 PM, Edwin Zimmerman wrote:
>> Fix cast-to-pointer compiler warning
>>
>> arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_srat_table’:
>> arch/x86/boot/compressed/acpi.c:316:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>>         ^
>> Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
>> Signed-off-by: Edwin Zimmerman <edwin@...mainstreet.net>
>> ---
>> arch/x86/boot/compressed/acpi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
>> index 25019d42ae93..5d2568066d58 100644
>> --- a/arch/x86/boot/compressed/acpi.c
>> +++ b/arch/x86/boot/compressed/acpi.c
>> @@ -313,7 +313,7 @@ static unsigned long get_acpi_srat_table(void)
>> * stash this in boot params because the kernel itself may have
>> * different ideas about whether to trust a command-line parameter.
>> */
>> - rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>> + rsdp = (struct acpi_table_rsdp *)(long)get_cmdline_acpi_rsdp();
>> if (!rsdp)
>> rsdp = (struct acpi_table_rsdp *)(long)
>>
> Lots of whitespace damage.  Probably your email client or some
> intermediary.
Email client, sorry.  Will resend.