linux-kernel - Re: [PATCH] mm: pagewalk: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200108112221.GA37977@arm.com>
Date:   Wed, 8 Jan 2020 11:22:22 +0000
From:   Steven Price <steven.price@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jérôme Glisse <jglisse@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Albert Ou <aou@...s.berkeley.edu>,
        Alexandre Ghiti <alex@...ti.fr>,
        Andy Lutomirski <luto@...nel.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Borislav Petkov <bp@...en8.de>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        James Hogan <jhogan@...nel.org>,
        James Morse <James.Morse@....com>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        Mark Rutland <Mark.Rutland@....com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Palmer Dabbelt <palmer@...ive.com>,
        Paul Burton <paul.burton@...s.com>,
        Paul Mackerras <paulus@...ba.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Russell King <linux@...linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Will Deacon <will@...nel.org>, Zong Li <zong.li@...ive.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Ralph Campbell <rcampbell@...dia.com>,
        John Hubbard <jhubbard@...dia.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: pagewalk: fix unused variable warning

On Tue, Jan 07, 2020 at 08:45:50PM +0000, Arnd Bergmann wrote:
> One of the pagewalk patches introduced a harmless warning:
> 
> mm/hmm.c: In function 'hmm_vma_walk_pud':
> mm/hmm.c:478:9: error: unused variable 'pmdp' [-Werror=unused-variable]
>   pmd_t *pmdp;
>          ^~~~
> mm/hmm.c:477:30: error: unused variable 'next' [-Werror=unused-variable]
>   unsigned long addr = start, next;
>                               ^~~~
> 
> Remove both of the now-unused variables.
> 
> Fixes: cb4d03d5fb4c ("mm: pagewalk: add p4d_entry() and pgd_entry()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Gah! Sorry about that, thanks for fixing it up.

Reviewed-by: Steven Price <steven.price@....com>

> ---
>  mm/hmm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/hmm.c b/mm/hmm.c
> index a71295e99968..72e5a6d9a417 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -474,8 +474,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
>  {
>  	struct hmm_vma_walk *hmm_vma_walk = walk->private;
>  	struct hmm_range *range = hmm_vma_walk->range;
> -	unsigned long addr = start, next;
> -	pmd_t *pmdp;
> +	unsigned long addr = start;
>  	pud_t pud;
>  	int ret = 0;
>  	spinlock_t *ptl = pud_trans_huge_lock(pudp, walk->vma);
> -- 
> 2.20.0
>