linux-kernel - Re: [PATCH v5 01/22] bootconfig: Add Extra Boot Config support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108090138.4fd561ac@gandalf.local.home>
Date:   Wed, 8 Jan 2020 09:01:38 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        Ingo Molnar <mingo@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Tim Bird <Tim.Bird@...y.com>, Jiri Olsa <jolsa@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Rob Herring <robh+dt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 01/22] bootconfig: Add Extra Boot Config support

On Wed, 8 Jan 2020 14:17:00 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > > +}
> > > +
> > > +/**
> > > + * xbc_node_is_key() - Test the node is a key node
> > > + * @node: An XBC node.
> > > + *
> > > + * Test the @node is a key node and return true if a key node, false if not.
> > > + */
> > > +static inline __init bool xbc_node_is_key(struct xbc_node *node)
> > > +{
> > > +	return !(node->data & XBC_VALUE);
> > > +}
> > > +  
> 
> Maybe this is better use xbc_node_is_value()
> 
> 	return !xbc_node_is_value();
> 
> Right?

Agreed.

-- Steve

>