linux-kernel - Re: [PATCH] efi/libstub: x86: fix unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jan 2020 15:04:23 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ard Biesheuvel <ardb@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        James Morse <james.morse@....com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        linux-efi <linux-efi@...r.kernel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Enrico Weigelt <info@...ux.net>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Dan Williams <dan.j.williams@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi/libstub: x86: fix unused-variable warning

On Wed, 8 Jan 2020 at 14:54, Arnd Bergmann <arnd@...db.de> wrote:
>
> The only users of these got removed, so they also need to be
> removed to avoid warnings:
>
> arch/x86/boot/compressed/eboot.c: In function 'setup_efi_pci':
> arch/x86/boot/compressed/eboot.c:117:16: error: unused variable 'nr_pci' [-Werror=unused-variable]
>   unsigned long nr_pci;
>                 ^~~~~~
> arch/x86/boot/compressed/eboot.c: In function 'setup_uga':
> arch/x86/boot/compressed/eboot.c:244:16: error: unused variable 'nr_ugas' [-Werror=unused-variable]
>   unsigned long nr_ugas;
>                 ^~~~~~~
>
> Fixes: 2732ea0d5c0a ("efi/libstub: Use a helper to iterate over a EFI handle array")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Oops

Acked-by: Ard Biesheuvel <ardb@...nel.org>

or I can add it to my next batch of EFI changes at the end of the week.

> ---
>  arch/x86/boot/compressed/eboot.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
> index da04948d75ed..57dfdc53d714 100644
> --- a/arch/x86/boot/compressed/eboot.c
> +++ b/arch/x86/boot/compressed/eboot.c
> @@ -114,7 +114,6 @@ static void setup_efi_pci(struct boot_params *params)
>         void **pci_handle = NULL;
>         efi_guid_t pci_proto = EFI_PCI_IO_PROTOCOL_GUID;
>         unsigned long size = 0;
> -       unsigned long nr_pci;
>         struct setup_data *data;
>         efi_handle_t h;
>         int i;
> @@ -241,7 +240,6 @@ setup_uga(struct screen_info *si, efi_guid_t *uga_proto, unsigned long size)
>         u32 width, height;
>         void **uga_handle = NULL;
>         efi_uga_draw_protocol_t *uga = NULL, *first_uga;
> -       unsigned long nr_ugas;
>         efi_handle_t handle;
>         int i;
>
> --
> 2.20.0
>