linux-kernel - Re: [PATCH v3] selftests/ftrace: fix glob selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108091155.4af8a2c5@gandalf.local.home>
Date:   Wed, 8 Jan 2020 09:11:55 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Shuah Khan <shuahkhan@...il.com>
Cc:     Sven Schnelle <svens@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] selftests/ftrace: fix glob selftest


Shuah,

Want to take this through your tree?

 https://lore.kernel.org/r/20200108074043.21580-1-svens@linux.ibm.com

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Thanks!

-- Steve


On Wed,  8 Jan 2020 08:40:43 +0100
Sven Schnelle <svens@...ux.ibm.com> wrote:

> test.d/ftrace/func-filter-glob.tc is failing on s390 because it has
> ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual
> __raw_spin_lock symbol isn't in the ftrace function list. Change
> '*aw*lock' to '*spin*lock' which would hopefully match some of the
> locking functions on all platforms.
> 
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> ---
> 
> Changes in v3:
>   change '*spin*lock' to '*pin*lock' to not match the beginning
> 
> Changes in v2:
>   use '*spin*lock' instead of '*ktime*ns'
> 
>  .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> index 27a54a17da65..f4e92afab14b 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc
> @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$'
>  ftrace_filter_check 'schedule*' '^schedule.*$'
>  
>  # filter by *mid*end
> -ftrace_filter_check '*aw*lock' '.*aw.*lock$'
> +ftrace_filter_check '*pin*lock' '.*pin.*lock$'
>  
>  # filter by start*mid*
>  ftrace_filter_check 'mutex*try*' '^mutex.*try.*'