linux-kernel - Re: [PATCH v10 2/2] watchdog: mtk_wdt: mt8183: Add reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e0a2ce4-0107-f49f-57fd-11b3b87dce45@gmail.com>
Date:   Wed, 8 Jan 2020 15:13:37 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nicolas Boichat <drinkcat@...omium.org>,
        Jiaxin Yu <jiaxin.yu@...iatek.com>
Cc:     Yong Liang <yong.liang@...iatek.com>, wim@...ux-watchdog.org,
        linux@...ck-us.net, Philipp Zabel <p.zabel@...gutronix.de>,
        linux-watchdog@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        chang-an.chen@...iatek.com, freddy.hsin@...iatek.com,
        Stephen Boyd <sboyd@...nel.org>,
        Yingjoe Chen <yingjoe.chen@...iatek.com>
Subject: Re: [PATCH v10 2/2] watchdog: mtk_wdt: mt8183: Add reset controller



On 08/01/2020 10:25, Nicolas Boichat wrote:
> On Mon, Jan 6, 2020 at 11:11 AM Jiaxin Yu <jiaxin.yu@...iatek.com> wrote:
>>
>> Add reset controller API in watchdog driver.
>> Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio,
>> camera, codec and connectivity) software reset functionality.
> 
> You add support for reset controller on both 8183 and 2712, do you
> want to say that in the commit title and message?
> 

I normally prefer to split that into at least two patches.

Regards,
Matthias

>>
>> Signed-off-by: yong.liang <yong.liang@...iatek.com>
>> Signed-off-by: Jiaxin Yu <jiaxin.yu@...iatek.com>
>> Reviewed-by: Yingjoe Chen <yingjoe.chen@...iatek.com>
>> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
>> ---
>>  drivers/watchdog/mtk_wdt.c | 105 ++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 104 insertions(+), 1 deletion(-)