linux-kernel - Re: [PATCH v5 3/4] regulator: mpq7920: add mpq7920 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108155056.GA4036@sirena.org.uk>
Date:   Wed, 8 Jan 2020 15:50:56 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Saravanan Sekar <sravanhome@...il.com>
Cc:     lgirdwood@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        mripard@...nel.org, shawnguo@...nel.org, heiko@...ech.de,
        sam@...nborg.org, icenowy@...c.io,
        laurent.pinchart@...asonboard.com, gregkh@...uxfoundation.org,
        Jonathan.Cameron@...wei.com, davem@...emloft.net,
        mchehab+samsung@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/4] regulator: mpq7920: add mpq7920 regulator driver

On Wed, Jan 08, 2020 at 02:12:33PM +0100, Saravanan Sekar wrote:

> +	for_each_child_of_node(np, child) {
> +		for (i = 0; i <= MPQ7920_BUCK4; i++) {
> +			struct regulator_desc *rdesc = &info->rdesc[i];
> +
> +			if (strcmp(rdesc->name, child->name))
> +				continue;

You can replace this loop with an of_parse_cb callback, please send an
incremental patch doing this.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)