linux-kernel - [PATCH] platform/chrome: wilco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200108093459.2.Ia8f971d42dcf892541a806b906414ddfbe4fea36@changeid>
Date:   Wed,  8 Jan 2020 09:35:20 -0700
From:   Daniel Campello <campello@...omium.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Daniel Campello <campello@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Duncan Laurie <dlaurie@...gle.com>,
        Nick Crews <ncrews@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: [PATCH] platform/chrome: wilco_ec: Fix unregistration order

Fixes the unregistration order on the Wilco EC core driver to follow the
christmas tree pattern.

Signed-off-by: Daniel Campello <campello@...omium.org>
---

 drivers/platform/chrome/wilco_ec/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c
index 5210c357feefd4..2d5f027d8770f8 100644
--- a/drivers/platform/chrome/wilco_ec/core.c
+++ b/drivers/platform/chrome/wilco_ec/core.c
@@ -137,9 +137,9 @@ static int wilco_ec_remove(struct platform_device *pdev)
 {
 	struct wilco_ec_device *ec = platform_get_drvdata(pdev);

+	platform_device_unregister(ec->telem_pdev);
 	platform_device_unregister(ec->charger_pdev);
 	wilco_ec_remove_sysfs(ec);
-	platform_device_unregister(ec->telem_pdev);
 	platform_device_unregister(ec->rtc_pdev);
 	if (ec->debugfs_pdev)
 		platform_device_unregister(ec->debugfs_pdev);
--
2.24.1.735.g03f4e72817-goog