linux-kernel - Re: [PATCH v2 09/36] platform/x86: intel_scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200108164141.GB32742@smile.fi.intel.com>
Date:   Wed, 8 Jan 2020 18:41:41 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Lee Jones <lee.jones@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Zha Qipeng <qipeng.zha@...el.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/36] platform/x86: intel_scu_ipc: Drop unused macros

On Wed, Jan 08, 2020 at 02:41:34PM +0300, Mika Westerberg wrote:
> These macros are not used anywhere in the driver so drop them.
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
>  drivers/platform/x86/intel_scu_ipc.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index 8db0644900a3..997fdac920c6 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -26,11 +26,7 @@
>  #include <asm/intel_scu_ipc.h>
>  
>  /* IPC defines the following message types */
> -#define IPCMSG_WATCHDOG_TIMER 0xF8 /* Set Kernel Watchdog Threshold */
> -#define IPCMSG_BATTERY        0xEF /* Coulomb Counter Accumulator */
> -#define IPCMSG_FW_UPDATE      0xFE /* Firmware update */
> -#define IPCMSG_PCNTRL         0xFF /* Power controller unit read/write */
> -#define IPCMSG_FW_REVISION    0xF4 /* Get firmware revision */
> +#define IPCMSG_PCNTRL         0xff /* Power controller unit read/write */
>  
>  /* Command id associated with message IPCMSG_PCNTRL */
>  #define IPC_CMD_PCNTRL_W      0 /* Register write */
> -- 
> 2.24.1
> 

-- 
With Best Regards,
Andy Shevchenko