[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200108165813.GA4472@bogus>
Date: Wed, 8 Jan 2020 10:58:13 -0600
From: Rob Herring <robh@...nel.org>
To: Andreas Klinger <ak@...klinger.de>
Cc: jic23@...nel.org, mark.rutland@....com, knaack.h@....de,
lars@...afoo.de, pmeerw@...erw.net, rpi-receiver@...-steyr.ac.at,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: devantech-srf04.yaml: add pm feature
On Thu, Jan 02, 2020 at 06:27:51PM +0100, Andreas Klinger wrote:
> Add GPIO line and startup time for usage of power management
>
> Signed-off-by: Andreas Klinger <ak@...klinger.de>
> ---
> .../bindings/iio/proximity/devantech-srf04.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> index 4e80ea7c1475..b3fcb3b79485 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> @@ -51,6 +51,22 @@ properties:
> the time between two interrupts is measured in the driver.
> maxItems: 1
>
> + power-gpios:
> + description:
> + Definition of the GPIO for power management of connected peripheral
> + (output).
> + This GPIO can be used by the external hardware for power management.
> + When the device gets suspended it's switched off and when it resumes
> + it's switched on again. After some period of inactivity the driver
> + get suspended automatically (autosuspend feature).
> + maxItems: 1
> +
> + startup-time-ms:
Why isn't this implied by the compatible string?
> + $ref: /schemas/types.yaml#/definitions/uint32
You can drop this for standard units.
0-2^32 is valid?
> + description:
> + This is the startup time the device needs after a resume to be up and
> + running.
> +
> required:
> - compatible
> - trig-gpios
> --
> 2.11.0
Powered by blists - more mailing lists