linux-kernel - Re: [PATCH RESEND v2 01/17] KVM: Remove kvm_read_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15bc02b7-595d-2564-b1f9-a4a8aae37252@redhat.com>
Date:   Wed, 8 Jan 2020 18:45:28 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Peter Xu <peterx@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        Christophe de Dinechin <dinechin@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH RESEND v2 01/17] KVM: Remove kvm_read_guest_atomic()

On 21/12/19 02:49, Peter Xu wrote:
> Remove kvm_read_guest_atomic() because it's not used anywhere.
> 
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
>  include/linux/kvm_host.h |  2 --
>  virt/kvm/kvm_main.c      | 11 -----------
>  2 files changed, 13 deletions(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index d41c521a39da..2ea1ea79befd 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -730,8 +730,6 @@ void kvm_get_pfn(kvm_pfn_t pfn);
>  
>  int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset,
>  			int len);
> -int kvm_read_guest_atomic(struct kvm *kvm, gpa_t gpa, void *data,
> -			  unsigned long len);
>  int kvm_read_guest(struct kvm *kvm, gpa_t gpa, void *data, unsigned long len);
>  int kvm_read_guest_cached(struct kvm *kvm, struct gfn_to_hva_cache *ghc,
>  			   void *data, unsigned long len);
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 13efc291b1c7..7ee28af9eb48 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -2039,17 +2039,6 @@ static int __kvm_read_guest_atomic(struct kvm_memory_slot *slot, gfn_t gfn,
>  	return 0;
>  }
>  
> -int kvm_read_guest_atomic(struct kvm *kvm, gpa_t gpa, void *data,
> -			  unsigned long len)
> -{
> -	gfn_t gfn = gpa >> PAGE_SHIFT;
> -	struct kvm_memory_slot *slot = gfn_to_memslot(kvm, gfn);
> -	int offset = offset_in_page(gpa);
> -
> -	return __kvm_read_guest_atomic(slot, gfn, data, offset, len);
> -}
> -EXPORT_SYMBOL_GPL(kvm_read_guest_atomic);
> -
>  int kvm_vcpu_read_guest_atomic(struct kvm_vcpu *vcpu, gpa_t gpa,
>  			       void *data, unsigned long len)
>  {
> 

Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>