linux-kernel - Re: [PATCH] kallsyms: work around bogus -Wrestrict warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200109140202.fd5488a2ac02f81b25d83b88@linux-foundation.org>
Date:   Thu, 9 Jan 2020 14:02:02 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Oleksandr Natalenko <oleksandr@...hat.com>, linux-mm@...ck.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Will Deacon <will@...nel.org>,
        Song Liu <songliubraving@...com>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Marc Zyngier <maz@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kallsyms: work around bogus -Wrestrict warning

On Wed, 8 Jan 2020 10:26:02 +0900 Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Hi Arnd,
> 
> On Tue,  7 Jan 2020 22:40:26 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > gcc -O3 produces some really odd warnings for this file:
> > 
> > kernel/kallsyms.c: In function 'sprint_symbol':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> >    strcpy(buffer, name);
> >    ^~~~~~~~~~~~~~~~~~~~
> > kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> >    strcpy(buffer, name);
> >    ^~~~~~~~~~~~~~~~~~~~
> > kernel/kallsyms.c: In function 'sprint_backtrace':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> >    strcpy(buffer, name);
> >    ^~~~~~~~~~~~~~~~~~~~
> > 
> > This obviously cannot be since it is preceded by an 'if (name != buffer)'
> > check.
> 
> Hmm, this looks like a bug in gcc.

Yes, we're getting a lot of such reports.  I don't think current gcc is
ready for this patch so I'll drop it, sorry.