linux-kernel - RE: [PATCH v9 09/13] exfat: add misc operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Jan 2020 08:41:50 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     'Valdis Klētnieks' <valdis.kletnieks@...il.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <hch@....de>,
        <sj1557.seo@...sung.com>, <linkinjeon@...il.com>, <tytso@....edu>
Subject: RE: [PATCH v9 09/13] exfat: add misc operations

> When compiling on a 32-bit system like Raspian on an RPi4, the compile
> dies:
> 
>   CC [M]  fs/exfat/misc.o
> fs/exfat/misc.c: In function 'exfat_time_unix2fat':
> fs/exfat/misc.c:157:16: error: 'UNIX_SECS_2108' undeclared (first use in
> this function); did you mean 'UNIX_SECS_1980'?
>   if (second >= UNIX_SECS_2108) {
>                 ^~~~~~~~~~~~~~
>                 UNIX_SECS_1980
> fs/exfat/misc.c:157:16: note: each undeclared identifier is reported only
> once for each function it appears in
> make[2]: *** [scripts/Makefile.build:266: fs/exfat/misc.o] Error 1
> 
> The problem is that the definition of UNIX_SECS_2108  is wrapped:
> 
> +#if BITS_PER_LONG == 64
> +#define UNIX_SECS_2108    4354819200L
> +#endif
> 
> but the usage isn't.
My mistake, Thanks for your check. I already fixed it on my git through
the Pali's report.
It will be in v10 patch.