linux-kernel - Re: [PATCH 05/16] media: isif: constify copied structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Jan 2020 07:13:30 +0000
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Julia Lawall <Julia.Lawall@...ia.fr>
Cc:     kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/16] media: isif: constify copied structure

On Wed, Jan 1, 2020 at 8:20 AM Julia Lawall <Julia.Lawall@...ia.fr> wrote:
>
> The isif_config_defaults structure is only copied into another
> structure, so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
>

Acked-by: Lad Prabhakar <prabhakar.csengg@...il.com>

Cheers,
--Prabhakar Lad

> ---
>  drivers/media/platform/davinci/isif.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c
> index b49378b18e5d..c98edb67cfb2 100644
> --- a/drivers/media/platform/davinci/isif.c
> +++ b/drivers/media/platform/davinci/isif.c
> @@ -29,7 +29,7 @@
>  #include "ccdc_hw_device.h"
>
>  /* Defaults for module configuration parameters */
> -static struct isif_config_params_raw isif_config_defaults = {
> +static const struct isif_config_params_raw isif_config_defaults = {
>         .linearize = {
>                 .en = 0,
>                 .corr_shft = ISIF_NO_SHIFT,
>