lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2020 09:46:55 +0900 From: AKASHI Takahiro <takahiro.akashi@...aro.org> To: Will Deacon <will@...nel.org> Cc: pasha.tatashin@...een.com, catalin.marinas@....com, will.deacon@....com, robh+dt@...nel.org, frowand.list@...il.com, bhsharma@...hat.com, kexec@...ts.infradead.org, linux-kernel@...r.kernel.org, james.morse@....com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v4 2/2] arm64: kexec_file: add crash dump support On Wed, Jan 08, 2020 at 05:48:39PM +0000, Will Deacon wrote: > On Mon, Dec 16, 2019 at 11:12:47AM +0900, AKASHI Takahiro wrote: > > Enabling crash dump (kdump) includes > > * prepare contents of ELF header of a core dump file, /proc/vmcore, > > using crash_prepare_elf64_headers(), and > > * add two device tree properties, "linux,usable-memory-range" and > > "linux,elfcorehdr", which represent respectively a memory range > > to be used by crash dump kernel and the header's location > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@...aro.org> > > Cc: Catalin Marinas <catalin.marinas@....com> > > Cc: Will Deacon <will.deacon@....com> > > Reviewed-by: James Morse <james.morse@....com> > > Tested-and-reviewed-by: Bhupesh Sharma <bhsharma@...hat.com> > > --- > > arch/arm64/include/asm/kexec.h | 4 + > > arch/arm64/kernel/kexec_image.c | 4 - > > arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++- > > 3 files changed, 106 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kexec.h b/arch/arm64/include/asm/kexec.h > > index 12a561a54128..d24b527e8c00 100644 > > --- a/arch/arm64/include/asm/kexec.h > > +++ b/arch/arm64/include/asm/kexec.h > > @@ -96,6 +96,10 @@ static inline void crash_post_resume(void) {} > > struct kimage_arch { > > void *dtb; > > unsigned long dtb_mem; > > + /* Core ELF header buffer */ > > + void *elf_headers; > > + unsigned long elf_headers_mem; > > + unsigned long elf_headers_sz; > > }; > > This conflicts with the cleanup work from Pavel. Please can you check my > resolution? [1] I don't know why we need to change a type of dtb_mem, otherwise it looks good. (I also assume that you notice that kimage_arch is of no use for kexec.) Thank you for the merge, -Takahiro Akashi > Will > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/diff/?h=for-kernelci&id=aef73191765a88cadc0a627cdc070e5a0086b015 >
Powered by blists - more mailing lists