linux-kernel - Re: [PATCH] usb: dwc3: use proper initializers for property entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tv55ro9b.fsf@kernel.org>
Date:   Thu, 09 Jan 2020 11:08:00 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: use proper initializers for property entries


Hi,

Marek Szyprowski <m.szyprowski@...sung.com> writes:

> Hi All,
>
> On 15.12.2019 17:41, Hans de Goede wrote:
>> Hi,
>>
>> On 13-12-2019 18:46, Dmitry Torokhov wrote:
>>> We should not be reaching into property entries and initialize them by
>>> hand, but rather use proper initializer macros. This way we can alter
>>> internal representation of property entries with no visible changes to
>>> their users.
>>>
>>> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
>>> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>> ---
>>>
>>> It would be good if this could go through Rafael's tree as it is needed
>>> for the rest of my software_node/property_entry rework patch series
>>> which I would love not to delay till 5.6.
>>
>> Patch looks good to me:
>>
>> Acked-by: Hans de Goede <hdegoede@...hat.com>
>
> This patch is instantly needed as the issue it fixes is again triggered 
> in current (20200107) linux-next by commit e6bff4665c59 "software node: 
> replace is_array with is_inline".
>
> Felipe: could You ack it, so it could be merged via Rafael's tree 
> together with related device property changes?

Here you go:

Acked-by: Felipe Balbi <balbi@...nel.org>

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)