linux-kernel - Re: [PATCH 02/12] i2c: i801: convert to use i2c_new_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Jan 2020 09:54:58 +0100
From:   Jean Delvare <jdelvare@...e.de>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/12] i2c: i801: convert to use i2c_new_client_device()

On Tue, 7 Jan 2020 18:47:36 +0100, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> Build tested only.
> 
>  drivers/i2c/busses/i2c-i801.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f5e69fe56532..44db3a91d32d 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1142,7 +1142,7 @@ static void dmi_check_onboard_device(u8 type, const char *name,
>  		memset(&info, 0, sizeof(struct i2c_board_info));
>  		info.addr = dmi_devices[i].i2c_addr;
>  		strlcpy(info.type, dmi_devices[i].i2c_type, I2C_NAME_SIZE);
> -		i2c_new_device(adap, &info);
> +		i2c_new_client_device(adap, &info);
>  		break;
>  	}
>  }
> @@ -1296,7 +1296,7 @@ static void register_dell_lis3lv02d_i2c_device(struct i801_priv *priv)
>  	memset(&info, 0, sizeof(struct i2c_board_info));
>  	info.addr = dell_lis3lv02d_devices[i].i2c_addr;
>  	strlcpy(info.type, "lis3lv02d", I2C_NAME_SIZE);
> -	i2c_new_device(&priv->adapter, &info);
> +	i2c_new_client_device(&priv->adapter, &info);
>  }
>  
>  /* Register optional slaves */
> @@ -1312,7 +1312,7 @@ static void i801_probe_optional_slaves(struct i801_priv *priv)
>  		memset(&info, 0, sizeof(struct i2c_board_info));
>  		info.addr = apanel_addr;
>  		strlcpy(info.type, "fujitsu_apanel", I2C_NAME_SIZE);
> -		i2c_new_device(&priv->adapter, &info);
> +		i2c_new_client_device(&priv->adapter, &info);
>  	}
>  
>  	if (dmi_name_in_vendors("FUJITSU"))

Reviewed-by: Jean Delvare <jdelvare@...e.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support