linux-kernel - Re: [PATCH v1 3/3] tty: documentation: abi: add ttyvs null modem driver sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Jan 2020 14:52:52 +0530
From:   rishi gupta <gupt21@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     robh+dt@...nel.org, jslaby@...e.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] tty: documentation: abi: add ttyvs null modem
 driver sysfs nodes

Oh sorry, I will update this.

On Tue, Jan 7, 2020 at 12:59 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Jan 06, 2020 at 12:51:55PM +0530, Rishi Gupta wrote:
> > The ttyvs driver exposes sysfs files to emulate various serial
> > port events. This commit document these files.
> >
> > Signed-off-by: Rishi Gupta <gupt21@...il.com>
> > ---
> >  .../ABI/testing/sysfs-devices-virtual-tty_ttyvs        | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> >
> > diff --git a/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs b/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> > new file mode 100644
> > index 0000000..69b04e0
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-devices-virtual-tty_ttyvs
> > @@ -0,0 +1,18 @@
> > +What:                /sys/devices/virtual/tty/ttyvsN/event
> > +Date:                January 2020
> > +Contact:     Rishi Gupta <gupt21@...il.com>
> > +KernelVersion:       5.5
> > +Description:
> > +             The ttyvs driver will emulate serial port event; parity error,
> > +             framing error, overrun error, asserting or de-asserting break
> > +             conditions and ring indication when user space application
> > +             writes an event code on this sysfs file.
>
> You did not actually document any of the values read/written to this
> file, like you did in your 0/X patch description :(
>
> greg k-h