[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DB3PR0402MB39167704253BE1FD4E106766F5390@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date: Thu, 9 Jan 2020 09:28:35 +0000
From: Anson Huang <anson.huang@....com>
To: Shawn Guo <shawnguo@...nel.org>
CC: "robh+dt@...nel.org" <robh+dt@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"andreas@...nade.info" <andreas@...nade.info>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect power
supply assignment
> Subject: RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
>
> Hi, Shawn
>
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove
> > > > incorrect power supply assignment
> > > >
> > > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > > The vdd3p0's input should be from external USB VBUS directly,
> > > > > NOT
> > > >
> > > > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V
> > > > which is suggested by vdd3p0 name.
> > > >
> > > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > > >
> > > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > > corresponding power supply for LDOs")
> > > >
> > > > Is it only a description correcting or is it fixing a real problem?
> > > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > > >
> > >
> > > It is fixing a real problem about USB LDO voltage, that is why we
> > > noticed
> > this issue.
> >
> > Okay, please describe the problem a little bit in the commit log.
> > Also squash the series into one patch, which is easier to be merged into -rc
> as a fix.
>
> OK, will send a new patch with squashing them together, but will NOT have
> the fix tag, is it OK? As the fix tag are different for each patch.
Never mind, I think I can put all 5 Fixes tag together in new patch.
Thanks,
Anson
Powered by blists - more mailing lists