linux-kernel - Re: linux-next: Fixes tag needs some work in the pinctrl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbZi3qV1RFvA4SDa_7T-b-eSaKGdA9_m4s_1gk=2MQNDQ@mail.gmail.com>
Date:   Thu, 9 Jan 2020 02:58:46 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ma Feng <mafeng.ma@...wei.com>
Subject: Re: linux-next: Fixes tag needs some work in the pinctrl tree

On Thu, Jan 9, 2020 at 1:28 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> In commit
>
>   d5d3594db9f0 ("pinctrl: armada-37xx: Remove unneeded semicolon")
>
> Fixes tag
>
>   Fixes: commit 5715092a458c ("pinctrl: armada-37xx: Add gpio support")
>
> has these problem(s):
>
>   - leading word 'commit' unexpected
>
> Also, each line listating a fixed commit should have a Fixes: prefix and
> all the commit message tags should be kept together at the end of the
> commit message.

Do we have to fix this? It is a trivial fix to a non-critial non-regression
problem so it's not like we need those Fixes tags to get it picked to
stable or anything. To me it's just some random free-form commit
message.

I have merged a bunch of pull requests on top so I need a real good
reason to back all that out. :/ it just doesn't seem worth it.

Yours,
Linus Walleij