linux-kernel - Re: [PATCH 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200109105557.gntbgzj3efbqpjwf@fsr-ub1664-175>
Date:   Thu, 9 Jan 2020 10:55:58 +0000
From:   Abel Vesa <abel.vesa@....com>
To:     Peng Fan <peng.fan@....com>
CC:     "sboyd@...nel.org" <sboyd@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Leonard Crestez <leonard.crestez@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anson Huang <anson.huang@....com>, Jacky Bai <ping.bai@....com>
Subject: Re: [PATCH 0/4] clk: imx: imx8m: introduce
 imx8m_clk_hw_core_composite

On 20-01-09 09:51:49, Peng Fan wrote:
> From: Peng Fan <peng.fan@....com>
> 
> To i.MX8M family, there are different types of clock slices,
> bus/core/ip and etc. Currently, the imx8m_clk_hw_composite
> api could only handle bus and ip clock slice, it could
> not handle core slice. The difference is core slice not have
> pre divider and the width of post divider is 3 bits.
> 
> To simplify code and reuse imx8m_clk_hw_composite, introduce a
> flag IMX_COMPOSITE_CORE to differentiate the slices.
> 
> With this new helper, we could simplify i.MX8M SoC clk drivers.
> 

I like the simplification this patchset adds, but maybe we should
keep the extra flags (or clock types) at the end of the API, so 
instead of imx8m_clk_hw_core_composite maybe we could use 
imx8m_clk_hw_composite_core.

Other than that:

Reviewed-by: Abel Vesa <abel.vesa@....com>

> Peng Fan (4):
>   clk: imx: composite-8m: add imx8m_clk_hw_core_composite
>   clk: imx: imx8mq: use imx8m_clk_hw_core_composite
>   clk: imx: imx8mm: use imx8m_clk_hw_core_composite
>   clk: imx: imx8mn: use imx8m_clk_hw_core_composite
> 
>  drivers/clk/imx/clk-composite-8m.c | 18 ++++++++++++++----
>  drivers/clk/imx/clk-imx8mm.c       | 17 +++++------------
>  drivers/clk/imx/clk-imx8mn.c       | 10 +++-------
>  drivers/clk/imx/clk-imx8mq.c       | 19 +++++--------------
>  drivers/clk/imx/clk.h              | 12 ++++++++++--
>  5 files changed, 37 insertions(+), 39 deletions(-)
> 
> -- 
> 2.16.4
>