linux-kernel - Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Jan 2020 17:39:05 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     John Stultz <john.stultz@...aro.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Todd Kjos <tkjos@...gle.com>,
        Alistair Delva <adelva@...gle.com>
Subject: Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers

On 08-01-20, 19:29, Greg Kroah-Hartman wrote:
> On Wed, Jan 08, 2020 at 06:00:48PM +0200, Mathias Nyman wrote:
 
> > 
> > Reviewing this always got bumped down on my todo list as other urgent issues
> > came up.
> > 
> > I think the concern about adding this amount of renesas specific code to
> > xhci-pci.c is valid. This series adds over 900 lines of Renesas FW loading
> > code to a 600 line xhci-pci.c
> 
> Yeah, that's not good, should be simple to split it into a separate file
> that's only build if that hardware is selected.

Okay let me redo the patches splitting it up. If you have any thoughts
about how that should be done, do let me know.

Thanks
-- 
~Vinod