linux-kernel - Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e71d1f3-f28a-1c34-3869-bc24b7caad32@microchip.com>
Date:   Thu, 9 Jan 2020 12:29:32 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <daniel.lezcano@...aro.org>, <tglx@...utronix.de>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-microchip-pit64b: fix sparse
 warning



On 09.01.2020 13:59, Daniel Lezcano wrote:
> On 06/01/2020 10:58, Claudiu Beznea wrote:
>> Fix sparse warning.
> 
> Mind to give the warning?

Sorry, is this one: "warning: Using plain integer as NULL pointer".

Would you like me to send v2 updating it with the warning?

Thank you,
Claudiu Beznea

> 
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
>> ---
>>  drivers/clocksource/timer-microchip-pit64b.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/timer-microchip-pit64b.c b/drivers/clocksource/timer-microchip-pit64b.c
>> index 27a389a7e078..bd63d3484838 100644
>> --- a/drivers/clocksource/timer-microchip-pit64b.c
>> +++ b/drivers/clocksource/timer-microchip-pit64b.c
>> @@ -248,6 +248,8 @@ static int __init mchp_pit64b_init_mode(struct mchp_pit64b_timer *timer,
>>       if (!pclk_rate)
>>               return -EINVAL;
>>
>> +     timer->mode = 0;
>> +
>>       /* Try using GCLK. */
>>       gclk_round = clk_round_rate(timer->gclk, max_rate);
>>       if (gclk_round < 0)
>> @@ -360,7 +362,7 @@ static int __init mchp_pit64b_dt_init_timer(struct device_node *node,
>>                                           bool clkevt)
>>  {
>>       u32 freq = clkevt ? MCHP_PIT64B_DEF_CE_FREQ : MCHP_PIT64B_DEF_CS_FREQ;
>> -     struct mchp_pit64b_timer timer = { 0 };
>> +     struct mchp_pit64b_timer timer;
>>       unsigned long clk_rate;
>>       u32 irq = 0;
>>       int ret;
>>
> 
> 
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 
>