[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdWM97k7iG_Er=VCLF0EPo6R1sK7+ZsSwjQB0b4WO88U6A@mail.gmail.com>
Date: Thu, 9 Jan 2020 13:42:48 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Mark Brown <broonie@...nel.org>,
linux-spi <linux-spi@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] spi: sh-msiof: Do not redefine STR while compile testing
Hi Krzysztof,
On Wed, Jan 8, 2020 at 8:43 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> STR is a well-known stringify macro so it should be avoided in drivers
> to avoid warnings like this (MIPS architecture while compile testing):
>
> drivers/spi/spi-sh-msiof.c:76:0: warning: "STR" redefined
> #define STR 0x40 /* Status Register */
> arch/mips/include/asm/mipsregs.h:30:0: note: this is the location of the previous definition
> #define STR(x) __STR(x)
>
> To maintain consistency between all register names add a SI prefix to
> all of them. This also matches register names in datasheet.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> ---
>
> Changes since v1:
> 1. Use SI prefix,
> 2. Adjust all register names.
Thanks for the update!
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
No changes in object file, so:
Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists