linux-kernel - Re: [PATCH v2 34/36] platform/x86: intel_pmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200109125727.GG2838@lahna.fi.intel.com>
Date:   Thu, 9 Jan 2020 14:57:27 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Lee Jones <lee.jones@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Zha Qipeng <qipeng.zha@...el.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 34/36] platform/x86: intel_pmc_ipc: Convert to MFD

On Thu, Jan 09, 2020 at 01:47:59PM +0200, Mika Westerberg wrote:
> > >  config INTEL_SOC_PMIC_BXTWC
> > >  	tristate "Support for Intel Broxton Whiskey Cove PMIC"
> > > -	depends on INTEL_PMC_IPC
> > > +	depends on MFD_INTEL_PMC_BXT
> > >  	select MFD_CORE
> > >  	select REGMAP_IRQ
> > >  	help
> > > @@ -632,6 +632,18 @@ config MFD_INTEL_MSIC
> > >  	  Passage) chip. This chip embeds audio, battery, GPIO, etc.
> > >  	  devices used in Intel Medfield platforms.
> > >  
> > > +config MFD_INTEL_PMC_BXT
> > > +	tristate "Intel PMC Driver for Broxton"
> > 
> > > +	depends on X86 && X86_PLATFORM_DEVICES && ACPI
> > 
> > Is the X86_PLATFORM_DEVICES dependency compulsory?
> > Quick grep shows that none of drivers (except nouveau) relies on it.
> 
> Well, we need that to be able to do the "select INTEL_SCU_IPC" below.
> I'm happy to change it if you have a better alternative ;-)

Just to provide more information. If I don't have that dependency I get
warnings like this:

WARNING: unmet direct dependencies detected for INTEL_SCU_IPC
  Depends on [n]: X86 [=y] && X86_PLATFORM_DEVICES [=n]
    Selected by [y]:
      - MFD_INTEL_PMC_BXT [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]