linux-kernel - Re: [EXT] [PATCH net-next v4 15/15] net: macsec: add support for offloading to the MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200109132126.GD5472@kwain>
Date:   Thu, 9 Jan 2020 14:21:26 +0100
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     Antoine Tenart <antoine.tenart@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "sd@...asysnail.net" <sd@...asysnail.net>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        "camelia.groza@....com" <camelia.groza@....com>,
        "Simon.Edelhaus@...antia.com" <Simon.Edelhaus@...antia.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>,
        Mark Starovoytov <mstarovoitov@...vell.com>
Subject: Re: [EXT] [PATCH net-next v4 15/15] net: macsec: add support for
 offloading to the MAC

Hi Igor,

On Mon, Dec 23, 2019 at 11:36:48AM +0000, Igor Russkikh wrote:
> 
> > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> > index 024af2d1d0af..771371d5b996 100644
> > --- a/include/uapi/linux/if_link.h
> > +++ b/include/uapi/linux/if_link.h
> > @@ -489,6 +489,7 @@ enum macsec_validation_type {
> >  enum macsec_offload {
> >  	MACSEC_OFFLOAD_OFF = 0,
> >  	MACSEC_OFFLOAD_PHY = 1,
> > +	MACSEC_OFFLOAD_MAC = 2,
> >  	__MACSEC_OFFLOAD_END,
> >  	MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1,
> 
> So from uapi perspective user have to explicitly specify "offload mac"
> or "offload phy"? And from non experienced user perspective he always
> have to try these two before rolling back to "offload none" ?
> 
> I'm not saying this is wrong, just trying to understand if there any
> more streamlined way to do this..

That is the idea, the commands will be:
# ip macsec offload macsec0 off
# ip macsec offload macsec0 phy
# ip macsec offload macsec0 mac

We should be able to report what's supported for a given interface, for
a more user friendly experience though. (We could include the
information in `ip macsec show` for example). Would that improve things?

Thanks!
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com