linux-kernel - Re: [PATCH v6 1/2] dt-bindings: net: bluetooth: add interrupts properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200109132917.GM30908@localhost>
Date:   Thu, 9 Jan 2020 14:29:17 +0100
From:   Johan Hovold <johan@...nel.org>
To:     guillaume La Roque <glaroque@...libre.com>
Cc:     Johan Hovold <johan@...nel.org>, Rob Herring <robh@...nel.org>,
        marcel@...tmann.org, johan.hedberg@...il.com,
        devicetree@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        nsaenzjulienne@...e.de, linux-kernel@...r.kernel.org,
        khilman@...libre.com
Subject: Re: [PATCH v6 1/2] dt-bindings: net: bluetooth: add interrupts
 properties

On Thu, Jan 09, 2020 at 02:13:23PM +0100, guillaume La Roque wrote:
> 
> On 1/9/20 11:53 AM, Johan Hovold wrote:
> > On Thu, Jan 09, 2020 at 11:42:56AM +0100, Guillaume La Roque wrote:
> >> add interrupts and interrupt-names as optional properties
> >> to support host-wakeup by interrupt properties instead of
> >> host-wakeup-gpios.
> >>
> >> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> >> ---
> >>  Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> >> index c44a30dbe43d..d33bbc998687 100644
> >> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> >> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> >> @@ -37,7 +37,9 @@ Optional properties:
> >>      - pcm-frame-type: short, long
> >>      - pcm-sync-mode: slave, master
> >>      - pcm-clock-mode: slave, master
> >> -
> >> + - interrupts: must be one, used to wakeup the host processor if
> >> +   gpiod_to_irq function not supported
> >> + - interrupt-names: must be "host-wakeup"
> > Looks like you forgot to address Rob's comment. If I understood him
> > correctly you either need to stick with "host-wakeup-gpios" (and fix
> > your platform) or deprecate it in favour of "interrupts":
> >
> > 	https://lkml.kernel.org/r/20191218203818.GA8009@bogus
> 
> not forgot marcel ask me a v6

Not much point in sending v6 before addressing feedback on v5.
Especially as Marcel asked for a v6 with acks. ;)

> for rob comment ok but it's not possible to support gpiod_to_irq on my
> platform.
> 
> if i deprecated it i need to update all DT with good interrupt number
> right?

Not sure. Perhaps just updating the binding is enough. Rob?

Johan