linux-kernel - Re: [PATCH] sched/psi: create /proc/pressure and /proc/pressure/{io|memory|cpu} only when psi enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200109153002.GA8547@cmpxchg.org>
Date:   Thu, 9 Jan 2020 10:30:02 -0500
From:   Johannes Weiner <hannes@...xchg.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Wang Long <w@...qinren.net>, mingo@...hat.com,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/psi: create /proc/pressure and
 /proc/pressure/{io|memory|cpu} only when psi enabled

On Wed, Jan 08, 2020 at 02:55:26PM +0100, Peter Zijlstra wrote:
> On Wed, Dec 18, 2019 at 08:38:18PM +0800, Wang Long wrote:
> > when CONFIG_PSI_DEFAULT_DISABLED set to N or the command line set psi=0,
> > I think we should not create /proc/pressure and
> > /proc/pressure/{io|memory|cpu}.
> > 
> > In the future, user maybe determine whether the psi feature is enabled by
> > checking the existence of the /proc/pressure dir or
> > /proc/pressure/{io|memory|cpu} files.
> 
> Works for me; Johannes?

Seems reasonable, and the patch looks good to me.

Acked-by: Johannes Weiner <hannes@...xchg.org>